Warning about method signature mismatch

keboola / db-extractor-mssql

MIT License

1 stars 2 forks source link

Warning about method signature mismatch #134

Open pivnicek opened 5 years ago

pivnicek commented 5 years ago

Running tests gives the warning

Warning: Declaration of Keboola\DbExtractor\Tests\AbstractMSSQLTest::getPrivateKey(): string should be compatible with Keboola\DbExtractor\Test\ExtractorTest::getPrivateKey(string $driver): string in /code/tests/Keboola/DbExtractor/AbstractMSSQLTest.php on line 12

ondrajodas commented 5 years ago

@pivnicek here https://github.com/keboola/db-extractor-mssql/pull/120 is fixed

pivnicek commented 5 years ago

@ondrajodas great! I'll take a look there 👍