Fix args of BCP cli command

keboola / db-extractor-mssql

MIT License

1 stars 2 forks source link

Fix args of BCP cli command #162

Closed michaljurecko closed 4 years ago

michaljurecko commented 4 years ago

Changes:

BCP cli command arguments were unescaped, so a more complex query (or password) could break the export.
It is fixed using escapeshellarg.
To BCP cli command was added -q parameter. It enables QUOTED_IDENTIFIERS, so behavior is same as PDO, and user can use FROM sales/FROM [sales]/FROM "sales" in query - and BCP will not fail.

michaljurecko commented 4 years ago

@ondrajodas pozrel by si sa prosim na to teraz rano + ak by si mohol potom aj dalsie PR cim skor vybavit, aby sa to stihlo a mohol si v riesit tie SSLka (dalsi tyzden mam dovolenku) .... a tento mssql extractor je na tom najhorsie co sa tyka refactoringu.