Catch invalid line breaks exception from CsvReader

keboola / db-extractor-mssql

MIT License

1 stars 2 forks source link

Catch invalid line breaks exception from CsvReader #172

Closed michaljurecko closed 4 years ago

michaljurecko commented 4 years ago

Error in log: https://my.papertrailapp.com/groups/23635/events?focus=1222931146619367425&q=%22keboola.ex-db-mssql%22%20AND%20%22exception%22%20AND%20%22attachment%22&selected=1222931146619367425

Slack: https://keboola.slack.com/archives/C09U3R1J4/p1595506745059500

Changes:

When BCP generates CSV with invalid line breaks, exception is catched and PDO fallback works.
There were missing catch in code.
I was not able to simulate the error locally.
It was working in previous version in same way:

ujovlado commented 4 years ago

@webrouse ak by si chcel, myslim, ze viem ako nasimulovat tie zle line breaks lokalne.

Staci ak do db vlozis line breaks \r a ides to exportovat bez akehokolvek replace char(10) a char(13)

michaljurecko commented 4 years ago

@ujovlado vdaka, to dava zmysel ... myslel som si, ze ide o chybu BCP, ... ale pozeral som si teraz v projekte ake data exportuje PDO fallback,... a su tam nejake XMLka asi s Mac zalomením riadkov.

Ono ta detekcia line breaks nie je velmi spolahliva, ... ono by sa to tam muselo prechadzat po znakoch, a brat do uvahy separatory a escapovanie, aby to bolo spolahlive. https://github.com/keboola/php-csv/blob/86f03def371e5b1a8a11973b496c86d3a0d4d57d/src/CsvReader.php#L112-L137

ujovlado commented 4 years ago

To len tak na okraj - ja som si to nahodou vsimol popri debugu ;)

michaljurecko commented 4 years ago

Fix v php-csv: https://github.com/keboola/php-csv/pull/41

michaljurecko commented 4 years ago

Fixol som to v php-csv, teda tento PR zatvaram a spravim novy: https://github.com/keboola/php-csv/pull/41