search

keboola / db-extractor-mssql

MIT License
1 stars 2 forks source link

Add CDC info to getTables #225

Closed ondrajodas closed 10 months ago

ondrajodas commented 10 months ago

Based on - https://github.com/keboola/db-extractor-mssql/pull/223

ondrajodas commented 10 months ago

jediná změna je tady - https://github.com/keboola/db-extractor-mssql/pull/225/commits/e40af6fd62afa32778efb4ae0395024e5ea9508c kde jsem nahradil INNER JOIN -> LEFT JOIN protože jediná možná příčina může být v tom že views neexistují v sys.tables

padající test je tam taky - https://github.com/keboola/db-extractor-mssql/pull/225/commits/994257acbe4dd080375e370ee0d0de9c8bac69de

pivnicek commented 10 months ago

@ondrajodas we don't need to check that it is added to metadata if true?

ondrajodas commented 10 months ago

@pivnicek doplnil jsem test kde v getTables zapnutý CDC - https://github.com/keboola/db-extractor-mssql/pull/225/commits/a7cadca6168e9be6b3f9adeb471353ad1db855b8

zároveň jsem ještě excludnul systémové tabulky vytvořené mssql serverem - https://github.com/keboola/db-extractor-mssql/pull/225/commits/2c6c969d923d799fb4a86dfe510ac2f161b64949

viz - https://learn.microsoft.com/en-us/sql/relational-databases/system-catalog-views/sys-objects-transact-sql?view=sql-server-ver16