search

keboola / db-extractor-mssql

MIT License
1 stars 2 forks source link

Support Incremental Fetching #68

Closed pivnicek closed 6 years ago

pivnicek commented 6 years ago

fixes #54

pivnicek commented 6 years ago

Thanks alot for the feedback @tomasfejfar , I'm going to update it accordingly. I agree that the way the export method is now is not at all ideal, but I don't really want to make that large of a refactor here. imho, the best time to make that kind of change is when moving to db-common 10.

pivnicek commented 6 years ago

ok @tomasfejfar , I think I've covered your must haves. Could you give it a last look for me? btw, #66 is required for this PR.

tomasfejfar commented 6 years ago

Cool, didn't know about setExpectedException, I only used expectException 👍