search

keboola / db-extractor-mssql

MIT License
1 stars 2 forks source link

More flexible incremental fetching #89

Closed pivnicek closed 5 years ago

pivnicek commented 5 years ago

Fixes #87

pivnicek commented 5 years ago

Live config test failing due to #91

pivnicek commented 5 years ago

ok @tomasfejfar I've updated this as per your suggestions, thank you.

pivnicek commented 5 years ago

Yes, it's not actually about an empty csv, it's an SQL server 2008 issue that I'm working on now (next PR coming today which should knock off another couple issues)

pivnicek commented 5 years ago

I'm going to merge this and make sure the build is fixed in the follow-up, thanks tom

tomasfejfar commented 5 years ago

I understand that this is a somewhat time sensitive, but merging with failing build seems like a very bad idea! I don't like it one bit. Make sure to fix it in the follow up ASAP!

pivnicek commented 5 years ago

Yup, it'll be fixed today. Unfortunately the only was to test against sql server 2008 is on that live config since we can't put it in a container.

pivnicek commented 5 years ago

I merged it mainly to make a cleaner diff in #97

pivnicek commented 5 years ago

@tomasfejfar rest assured I've removed the problematic timestamp column from the sql2008 server test table so the build passes now. https://travis-ci.com/keboola/db-extractor-mssql/builds/94263562 Going to release this, and then finish that follow up.