Timestamp fix for sql server 2008

keboola / db-extractor-mssql

MIT License

1 stars 2 forks source link

Closed pivnicek closed 5 years ago

pivnicek commented 5 years ago

Fixes: #96 #91 and #90

pivnicek commented 5 years ago

@tomasfejfar you're going to "love" this one. Since can't get a container for sql2008, the fix assurance is in the live config test here: namely this table hase a timestamp column: https://connection.keboola.com/admin/projects/2703/extractors/keboola.ex-db-mssql/402532849/query/32057

pivnicek commented 5 years ago

@tomasfejfar thanks! I've updated it. In the end I think the main thing this fixes is #90

tomasfejfar commented 5 years ago

It indeed tries to fix a lot of things at once :) But I'm pretty confident it fixes #90...

pivnicek commented 5 years ago

OK @tomasfejfar I added those column -> sql tests, I think that was a good idea, thanks.

tomasfejfar commented 5 years ago

Great! :)