Columns order

[Halama]

@MiroCillik odin nasadil tu upravu a sloupce v manifestu presne reflektuji to jak to bylo vyexportovane. Otestoval jsem to ruznymi zverstvy tady https://connection.keboola.com/admin/projects/4088/writers/keboola.wr-db-snowflake/349938950 a slape to dobre.

Teoreticky by se teda nemuselo v tom extractoru upravovat nic.

[Halama]

Takže možná v tomhle PR zachovej jenom ten cleanup/refactoring?

[Halama]

Jdu odpovědět na issue.

[MiroCillik]

Okej, necham teda len ten cleanup/refactoring

On 31 Jan 2018 11:09, "Martin Halamíček" notifications@github.com wrote:

Jdu odpovědět na issue.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/keboola/db-writer-redshift/pull/12#issuecomment-361884977, or mute the thread https://github.com/notifications/unsubscribe-auth/ABa0jxL4m93GtfYgON0uC-eizhIKT8NLks5tQDvagaJpZM4Rw5bO .

[MiroCillik]

Vlastne, nechal by som to tak ako je to v tomto PR. Nech to nerobi ten reordering, ale nech to vyhodi chybu pokial by nahodu ten manifest mal ine poradie stlpcov ako konfigurace / input mapping.

[Halama]

To je asi zodpovednost docker runneru zarucit ze do toho manifestu to posle stejne jako to mel v IM. Takze v komponente bych to netestoval.

[Halama]

Jeste si to checkoutnu a poradne a zkouknu to jakym zpusobem se tam pracuje s items v parameterch.

[MiroCillik]

Ok, takze to nekontrolovat vobec. Teoreticky by tam ta kontrola bola zbytocna.. Suhlasim.

[Halama]

JJ to by se tam pak mohlo kontrolovat uplne vsechno.

Kde ale teoreticky muze treba rucni manipulaci dojit k rozdilum je rozhozeni IM a toho co je v items.

[MiroCillik]

Ok, takze som ten check prerobil aby skontroloval ci sedia stlpce v konfigu tabulky oproti input mappingu

[Halama]

ok, super zitra zkouknu

[MiroCillik]

Prohazeny poradi se tam testuje, ale tu kontrolu som teda zjednodusil na "!=="

[Halama]

diky, releasnu to.