search

keboola / db-writer-snowflake

Snowflake database writer
MIT License
0 stars 1 forks source link

Upgrade to DB Writer common 4.0.0 #46

Closed ErikZigo closed 5 years ago

ErikZigo commented 5 years ago

tenhle upgrade ma upravy primarne v testech

ErikZigo commented 5 years ago

@MiroCillik @pivnicek muzete na to kouknout? Rad bych to nasadil a venoval se upgradu na common 5.x

MiroCillik commented 5 years ago

@ErikZigo ja som na to vcera rano pozeral, ale zabudol som ti napisat. Vyzera to dobre.

ErikZigo commented 5 years ago

@MiroCillik btw jsem v common 5 narazil na jednu vec se kterou teda si ted nevim rady. Ty tam mas nadefinovany interface ze metody createConnection/getConnection vraci \PDO. Ne ale vsechny writery pouzivaji PDO.

MiroCillik commented 5 years ago

@ErikZigo jj, s tym som sa stretol pri Oracle myslim. Vsetky ostatne co som teraz pozeral (RS, MSSQL, PgSQL) pouzivaju \PDO.. Pozriem na to a premyslim to. Mozme to prediskutovat, tiez pozriem ako je to spravene v DB ex teraz.

MiroCillik commented 5 years ago

@ErikZigo asi by som to zatial vyriesil tak, ze pretazis constructor a tu funkciu createConnection() nazves nejak inac. A mozes zalozit issue do db-writer-common. Ten by potom chcelo updatnut podobne ako db-extractor-common aby vyuzival tu Keboola\Component atd..