search

keboola / ex-facebook-graph-api

facebook graph api extractor(insights and fb-ads intended)
MIT License
39 stars 8 forks source link

always provide nonempty end_time when parsing insights #18

Open kacurez opened 7 years ago

kacurez commented 7 years ago

k vacsine metrik fb dodava end_time property ktora sa viaze k obdobiu za ktore je metrika vypocitana. Pre vacsinu post insights metrik to proste nevracia a tak dava zmysel end_time doplnit na current day v pripade ze ho fb api nevrati.

kacurez commented 7 years ago

riesenie: staci update tu https://github.com/keboola/ex-facebook-graph-api/blob/ac5e15e3bd97dd6511a3a9eb0fbfdbb48257fe23/src/keboola/facebook/api/parser.clj#L106 ale potom bude treba pregenerovat vsetky insights regresivne testy.

Tiez je otazka ci to "neohrozi" existujuce data klientov