search

keboola / php-component

General library for PHP applications running in Keboola Connection environment
MIT License
0 stars 1 forks source link

Write manifest method with array of manifest options? #15

Closed ujovlado closed 6 years ago

ujovlado commented 6 years ago

Right now, if i want to create manifest file with incremental turned on I have to write:

$manifestManager = new ManifestManager($outputPath);
$manifestManager->writeTableManifest(
                        $outputPath . '/' .$webalizedExportName . '.csv',
                        '',
                        [],
                        [],
                        $exportOptions['incremental']
                    );

For me, using it like this would be more easier:

$manifestManager = new ManifestManager($outputPath);
$manifestManager->writeTableManifest($outputPath . '/' .$webalizedExportName . '.csv', [
   "incremental" => true
]);

I understand this is a BC break.

odinuv commented 6 years ago

how about writeTableManifestFromArray ? https://github.com/keboola/php-component/blob/master/src/Manifest/ManifestManager.php#L109

ujovlado commented 6 years ago

omg, rtfm :100: