optional timestamp

[pivnicek]

So, was thinking something like this to make _timestamps optional. If you agree, I'll write up the tests and RS version etc...

[Halama]

@pivnicek it look good but some array $options parameter whould be better than boolean flag parameter. So then it code it would look like:

$import->import('my-table', $columns, $sourceData, [
  'addTimestamp' => false,
]);

[Halama]

Also it would be more clear to put this as parameter of insertAllIntoTargetTable instead of make it class variable.

[pivnicek]

Great! Agreed. I'll flush it out.

[pivnicek]

I guess I'll add it for insertOrUpdateTargetTable also. If we'll support optional timestamp it should be completely supported imo.

[Halama]

@pivnicek ok, add it to insertOrUpdateTargetTable please too

[Halama]

don't forget to tests, every feature should be developed by tests.

[pivnicek]

OK, this may need a sanity check, but this should cover support for RS and SNFLK full table and incremental loading optional timestamp usage.

[Halama]

@pivnicek the tests are failing

[pivnicek]

damn, sorry :/ mmt

[pivnicek]

that's better