search

keboola / php-db-import

MIT License
4 stars 0 forks source link

Edit Exception handler #70

Closed romanbracinik closed 4 years ago

romanbracinik commented 4 years ago

Potrebujem opravit chyby ktore este vznikaju pouzitim v https://github.com/keboola/db-extractor-snowflake/pull/99 a to konkretne ErrorException: odbc_prepare(): supplied resource is not a valid ODBC-Link resource opravoval som tu predtim ten disconnect 

public function disconnect(): void
    {
        if (is_resource($this->connection)) {
            odbc_close($this->connection);
        }
    }

Ale zacalo to padat este na hore spominanej chybe bude to asi zle osterenymi vynimkami. Nasiel som v https://github.com/keboola/db-adapter-snowflake inac spravene tie Exceptions. Myslis ze by to malo pomoct ? Snazil som sa rozbehat tie testy aj lokalne ale moc mi to neslo takze neviem presne vyskusat ci to pomoze, ale ako pise Erik tu https://keboola.slack.com/archives/CFVRE56UA/p1575996841082400 Tam mozna ty credentials budou mit nejaky o mezeny prava, to vyhodi vyjimku ale diky spatnymu error handlingu to hodi tohle.

romanbracinik commented 4 years ago

Jo mas pravdu, spravim to tak ;)