search

keboola / php-utils

A set of utility functions
MIT License
0 stars 1 forks source link

Add sanitizeName for sapi consistency #2

Closed pivnicek closed 6 years ago

pivnicek commented 6 years ago

needed for https://github.com/keboola/db-extractor-common/issues/38

pivnicek commented 6 years ago

Good points, thanks!

pivnicek commented 6 years ago

I think it's better now. thanks for eyes @tomasfejfar

pivnicek commented 6 years ago

I ended up changing it to sanitizeColumnName because I saw it was some missing logic that was here: https://github.com/keboola/connection/blob/master/library/Keboola/Filter/ColumnNameFilter.php

dataProviders are there, natural great idea (these other tests here could use them too:)

pivnicek commented 6 years ago

got to be careful here with the system differences locally versus travis. I get different test results locally. we should dockerize it. But I don't want to spend much more time here than necessary.

pivnicek commented 6 years ago

tak @tomasfejfar muzu to mergnout?