keboola / syrup

Thick viscous liquid
MIT License
0 stars 0 forks source link

API blank page fix #114 #115

Closed ErikZigo closed 6 years ago

ErikZigo commented 6 years ago

V Debug\ExceptionHandler byl od verze https://github.com/keboola/syrup/releases/tag/6.1.0 bug. API koncilo 500 a bilou strankou, pokud doslo k nejake vyjimce, kterou neodchytil SyrupExpcetionListener.

Realne se to projevilo az pri volani API komponenty s tokenem projektu kde probihala maintenance. Za to mohl bug v konstruktoru SyrupExpcetionListener, kde se pouzival SapiClient ale neodchytavaly jeho vyjimky.

Zaroven jsem upravil podobu api odpovedi.

U Syrup < 6.1.0 to vracelo

HTTP 503

{
    "status": "error",
    "message": "An error occured. Please contact support@keboola.com",
    "exceptionId": "componentId-430d1f8ae1deccf32bdafe960e6aca9b"
}

Nove bude vracet

HTTP 503

{
    "status": "error",
    "error": "Project is disabled",
    "code": 503,
    "message": "Project is disabled - reasonForDisable",
    "exceptionId": "componentId-9cb6005f067d875ba7d92bd5ea974c6a",
}
ErikZigo commented 6 years ago

Doplneny testy Debug\ExceptionHandler a test funkcniho initu SyrupExceptionListeneru pri maintenance.

ErikZigo commented 6 years ago

@odinuv @MiroCillik tak ja to asi mergnu a releasnu?