Version 2.12.0 pushed to Helm repository with CRLF endings

zmarouf commented 12 months ago

The 2.12.0 Helm chart update seems to be pushed with CRLF endings. Git repository seems okay.

Expected Behavior

LF line terminators when pushing the Chart to the Helm Repository.

Actual Behavior

CRLF, LF line terminators according to file

Using Helm template
In a repository that pulls the chart via Carvel vendir
This breaks consistency with tooling that monitors Chart updates.
Git warns of changes on every single file e.g

warning: in the working copy of 'charts/keda/templates/cert-manager/keda-tls-certificate.yaml', CRLF will be replaced by LF the next time Git touches it

Steps to Reproduce the Problem

helm template kedacore/keda --version 2.11.0 -n keda > keda.2.11.0.yaml
helm template kedacore/keda --version 2.12.0 -n keda > keda.2.12.0.yaml
file keda.2.11.0.yaml keda.2.12.0.yaml

keda.2.11.0.yaml: ASCII text
keda.2.12.0.yaml: ASCII text, with CRLF, LF line terminators

Specifications

KEDA Version: 2.12.0
Platform & Version: Linux and BSD
Kubernetes Version: N/A
Scaler(s): N/A

JorTurFer commented 12 months ago

@tomkerkhove @zroubalik , should we push again the chart or just being more care in the future?

zroubalik commented 12 months ago

I would wait for next releases and make sure to use a proper OS for it ;)

JorTurFer commented 12 months ago

Maybe we can take this issue as a good reason for deploying somehow the charts in a more automated way, WDYT?

zroubalik commented 12 months ago

Agree, let's track this somewhere

kedacore / charts