feat: add interceptor TLS support to the add-on chart

kedacore / charts

Helm charts for KEDA

Apache License 2.0

152 stars 216 forks source link

feat: add interceptor TLS support to the add-on chart #642

Closed zorocloud closed 3 months ago

zorocloud commented 4 months ago

Provide a description of what has been changed

Checklist

[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
[x] README is updated with new configuration values (if applicable) learn more
[x] A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

Adding support for TLS to the interceptor proxy in the HTTP Add-on. Resolves https://github.com/kedacore/http-add-on/issues/1028

zorocloud commented 4 months ago

Re the 3rd item in the checklist (updating the README), do I need to run helm-docs to generate a new README now or will that be done at the time of release?

kamialie commented 3 months ago

@zorocloud considering the fact that when I ran it for my PR I noticed that some change from another PR was applied, I believe you have to run it yourself.

zroubalik commented 3 months ago

Re the 3rd item in the checklist (updating the README), do I need to run helm-docs to generate a new README now or will that be done at the time of release?

yes please

zorocloud commented 3 months ago

Thanks for confirming. I have updated the PR post running helm-docs now :+1: .

JorTurFer commented 3 months ago

Thanks! ❤️