search

kedacore / keda-docs

Documentation and landing page for KEDA
https://keda.sh
Apache License 2.0
124 stars 436 forks source link

Misleading recommendation on Scaling Deployments section #1431

Open 0x2b3bfa0 opened 2 months ago

0x2b3bfa0 commented 2 months ago

Since https://github.com/kedacore/keda-docs/pull/265, the documentation provides a note stating that the preStop hook can be used to delay termination:

https://github.com/kedacore/keda-docs/blob/5ef378ea14b1bc2a9e90bc05e492b2ebed3faafa/content/docs/1.5/concepts/scaling-deployments.md?plain=1#L107

Unfortunately, containers will still receive SIGKILL after terminationGracePeriodSeconds have elapsed, regardless of the preStop hook, which is just used to delay the initial SIGTERM sent for graceful termination.

With the current wording of this note, I thought for a moment that the preStop hook would take precedence over terminationGracePeriodSeconds and preventing Kubernetes from sending SIGKILL until the hook finished running.

zroubalik commented 1 month ago

Makes sense, are you willing to contribute an improvement here?