kedacore / keda-docs

Documentation and landing page for KEDA
https://keda.sh
Apache License 2.0
121 stars 441 forks source link

Fix Cloudwatch documentation suggesting invalid conditions #1462

Closed nicolajv closed 1 week ago

nicolajv commented 2 months ago

Provide a description of what has been changed

The currently documentation incorrectly assumes the ability to scope down KEDA GetMetricData permissions by the use of conditions. However as shown in the official Actions defined by Amazon CloudWatch documentation, GetMetricData does not support any condition keys.

Checklist

github-actions[bot] commented 2 months ago

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

netlify[bot] commented 2 months ago

Deploy Preview for keda ready!

Name Link
Latest commit 3c902f3ac4239dec0bfe2399d2f649ea9819b5b9
Latest deploy log https://app.netlify.com/sites/keda/deploys/672874e4ee01dc0008b9a885
Deploy Preview https://deploy-preview-1462--keda.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

robpickerill commented 1 week ago

This is correct, and my mistake, putmetricdata has a condition, not getmetricdata