kedacore / keda-olm-operator

Operator for deploying KEDA Controller on OperatorHub.io/OLM
Apache License 2.0
31 stars 23 forks source link

Change the way resources yaml file is being loaded #106

Open zroubalik opened 3 years ago

zroubalik commented 3 years ago

At the moment the resources file is being loaded into the operator during the startup: https://github.com/kedacore/keda-olm-operator/blob/cbd80d4af6e95d5f0ad36af6631d3a8a008c5e3e/controllers/keda/kedacontroller_controller.go#L76-L83

It would be better to use go embed feature introduced in Go 1.16: https://golangtutorial.dev/tips/embed-files-in-go/

husnialhamdani commented 1 year ago

Hi @zroubalik, Can I work on this?

zroubalik commented 1 year ago

@husnialhamdani absolutely, please coordinate with @joelsmith, he is the main point of contact for this repo.

joelsmith commented 1 year ago

@husnialhamdani, that would be great, thanks! Let me know if you have any questions along the way

husnialhamdani commented 1 year ago

@joelsmith @zroubalik Thanks for assigning, want to confirm if my understanding correct, So we have to change the way to load the resources with Go embed in this file ?