kedacore / keda-olm-operator

Operator for deploying KEDA Controller on OperatorHub.io/OLM
Apache License 2.0
31 stars 23 forks source link

some mistakes in Kedacontoller spec examples in Readme.md #115

Closed dudniksergei closed 2 years ago

dudniksergei commented 2 years ago

A clear and concise description of what the bug is.

Expected Behavior

requests should be less or equal than limits in KedaConroller example.

Actual Behavior

requests are more that limits

  ## Manage resource requests & limits for KEDA Operator
  # https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
  # resourcesKedaOperator:
  #   limits:
  #     cpu: 100m
  #     memory: 100Mi
  #   requests:
  #     cpu: 1000m
  #     memory: 1000Mi

  ## Manage resource requests & limits for KEDA Metrics Server
  # https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/
  # resourcesMetricsServer:
  #   limits:
  #     cpu: 100m
  #     memory: 100Mi
  #   requests:
  #     cpu: 1000m
  #     memory: 1000Mi

Steps to Reproduce the Problem

  1. use example resource definition
  2. keda contoller installation failed

Specifications

zroubalik commented 2 years ago

Good catch, thanks! It should be obviously the other way round. I am gonna fix this typo.