Allow operand images to be specified by env vars

kedacore / keda-olm-operator

Operator for deploying KEDA Controller on OperatorHub.io/OLM

Apache License 2.0

31 stars 23 forks source link

Allow operand images to be specified by env vars #149

Closed joelsmith closed 2 years ago

joelsmith commented 2 years ago

This allows a CSV to specify KEDA_OPERATOR_IMAGE and/or KEDA_METRICS_SERVER_IMAGE in the operator's deployment in order to use an alternate set of controllers.

Checklist

[X] Commits are signed with Developer Certificate of Origin (DCO)

joelsmith commented 2 years ago

@zroubalik do you have any good ideas on how to add an automated test? I have manually tested the new functionality by creating a bundle which deploys the olm operator with the env vars, but any automated test I do which tries to make changes to to the olm operator's env vars via its deployments, OLM just reverts the changes.

zroubalik commented 2 years ago

@joelsmith I see, so maybe at least add a small unit test for the replaceContainerImage() in transform.go.

If that's too much burden, let's merge it without the test, no problem.