kedacore / keda-olm-operator

Operator for deploying KEDA Controller on OperatorHub.io/OLM
Apache License 2.0
30 stars 23 forks source link

Use KEDA-specific annotation name for last config #201

Closed joelsmith closed 11 months ago

joelsmith commented 11 months ago

Manifestival > v0.7.2 has the ability to use an app-specific annotation name so that our changes don't conflict with kubectl-applied changes.

Deps updates:

  go get github.com/manifestival/manifestival@f20c69532c27cff6358cd681be7a477b8c897d54
  go get k8s.io/apiserver@v0.27.3
  go mod tidy

Checklist

joelsmith commented 11 months ago

@zroubalik when you have a moment, please take a look at this. I made the change to fix an issue my customer is running into where when ArgoCD is used to add labels to objects which are also managed by the OLM operator, they revert each other's changes on each reconcile iteration.

By using our own annotation name for the last-applied-config field, we won't try to manage fields which were added by other processes which happen to be using kubectl to add labels or annotations to our objects.