kedacore / keda-olm-operator

Operator for deploying KEDA Controller on OperatorHub.io/OLM
Apache License 2.0
30 stars 23 forks source link

Allow operator to install resources to WATCH_NAMESPACE instead of requiring keda ns #203

Closed joelsmith closed 10 months ago

joelsmith commented 11 months ago

Currently the KEDA OLM operator is hard-coded to work only in the keda namespace.

This change makes it so that whichever namespace the KEDA operator is installed to, the operands (and required resources) will be installed to the same namespace.

The fundamental difference: Before:

After:

Checklist

joelsmith commented 10 months ago

@zroubalik thanks for the review! I had a few final tasks which are now done. (I renamed a variable as suggested by your review comment, I switched the unit tests to use ginkgo to get rid of a CI test error, and I updated the docs to match the new behavior.)

If you have time for a final review, that would be great. If not, I can have somebody from my team review it -- now that I know you're okay with the general approach.