search

kedacore / keda-olm-operator

Operator for deploying KEDA Controller on OperatorHub.io/OLM
Apache License 2.0
31 stars 22 forks source link

Add option to select keda release to KedaController CRD #217

Closed josefkarasek closed 8 months ago

josefkarasek commented 9 months ago

New config option kedaRelease in kedacontroller.spec. The intention is to use the operator to deploy specific keda release.

If accepted, multiple manifest versions/releases will need to be baked into the image. For example last three KEDA releases.

Checklist

josefkarasek commented 9 months ago

Another note - do we allow updating and downgrading via updates on KedaController? If so, this should be tested.

I manually tried to move forward and backwards between releases v2.10.1, v2.12.0 and v2.12.1 and KEDA, metrics + webhook servers were deployed successfully.

zroubalik commented 9 months ago

@joelsmith is this change okay with you?

zroubalik commented 9 months ago

@joelsmith @jkyros are you comfortable with this change please?

joelsmith commented 9 months ago

I am fine with the concept of the change, although I believe we would want to add a way to disable this feature for distributors who want the versions to be more tightly coupled (i.e. preserve current behavior).

However, this PR makes a lot of changes that I was not expecting to see when I read the PR title. I will need to allocate time in my schedule to do a thorough review of the changes to the manifest handling, etc.

zroubalik commented 9 months ago

I am fine with the concept of the change, although I believe we would want to add a way to disable this feature for distributors who want the versions to be more tightly coupled (i.e. preserve current behavior).

However, this PR makes a lot of changes that I was not expecting to see when I read the PR title. I will need to allocate time in my schedule to do a thorough review of the changes to the manifest handling, etc.

Sounds good, how would you prefer to add the option to disable this feature? ENV variable or a parameter? Or even a build-time option?

zroubalik commented 9 months ago

@joelsmith have you got a chance to look at this please?

josefkarasek commented 8 months ago

Closing this PR.

I went over the design with Zbynek again and we're worried about the amount of time thaw would be spent on testing that upgrades work. We need to go back to the drawing board for a bit.