search

kedacore / keda-olm-operator

Operator for deploying KEDA Controller on OperatorHub.io/OLM
Apache License 2.0
30 stars 23 forks source link

Prevent namespace creation/modification when installing via OLM #235

Closed joelsmith closed 3 weeks ago

joelsmith commented 3 weeks ago

Since OLM installs the operator to an existing namespace, there is little (no?) value in having this operator try to manage the namespace where it is already running. Also, we have an apparent bug where we always create/manage the keda namespace even if the operator is running in a different namespace.

Checklist

maxcao13 commented 3 weeks ago

Makes sense to me! Couldn't find that when I was looking.

Just wondering then (for my own knowledge), is there a reason to keep this part

apiVersion: v1
kind: Namespace
metadata:
  labels:
    app.kubernetes.io/name: keda
    app.kubernetes.io/part-of: keda-operator
    app.kubernetes.io/version: 2.13.1
  name: keda
---

in the resources/keda.yaml? Completeness?

/lgtm

joelsmith commented 3 weeks ago

Just wondering then (for my own knowledge), is there a reason to keep this part

That's a good question. It's because each time we do a release of the OLM operator, part of the process is to pull that file from the corresponding main KEDA release. So if we remove it, we would have to change the process to filter it out next time we sync with that repo or it would re-appear.