kedacore / keda-olm-operator

Operator for deploying KEDA Controller on OperatorHub.io/OLM
Apache License 2.0
31 stars 22 forks source link

Prepare release 2.16.0 #247

Closed joelsmith closed 3 weeks ago

joelsmith commented 3 weeks ago

The first two commits are pre-requisite for the rest of the process. They (1) tidy up the github actions and prepare for switching to go 1.23 and (2) make the relprep script use X.YY instead of X.YY.ZZ versions for envtest, which seems more reliable (and possibly required now).

$ ./hack/relprep.sh 2.16.0
$ go get sigs.k8s.io/structured-merge-diff/v4@v4.4.1
$ go mod tidy

Manually downgraded sigs.k8s.io/structured-merge-diff/v4 due to mis-matched struct in v4.4.2.

Checklist

Fixes #246

github-actions[bot] commented 3 weeks ago

Diff 2.16.0/manifests/eventing.keda.sh_cloudeventsources.yaml \& 2.15.1/manifests/eventing.keda.sh_cloudeventsources.yaml

```diff 6c6 < controller-gen.kubebuilder.io/version: v0.15.0 --- > controller-gen.kubebuilder.io/version: v0.16.5 9c9 < app.kubernetes.io/version: 2.15.1 --- > app.kubernetes.io/version: 2.16.0 89,90d88 < description: CloudEventType contains the list of cloudevent < types 93a92,101 > - keda.scaledobject.removed.v1 > - keda.scaledjob.ready.v1 > - keda.scaledjob.failed.v1 > - keda.scaledjob.removed.v1 > - keda.authentication.triggerauthentication.created.v1 > - keda.authentication.triggerauthentication.updated.v1 > - keda.authentication.triggerauthentication.removed.v1 > - keda.authentication.clustertriggerauthentication.created.v1 > - keda.authentication.clustertriggerauthentication.updated.v1 > - keda.authentication.clustertriggerauthentication.removed.v1 98,99d105 < description: CloudEventType contains the list of cloudevent < types 102a109,118 > - keda.scaledobject.removed.v1 > - keda.scaledjob.ready.v1 > - keda.scaledjob.failed.v1 > - keda.scaledjob.removed.v1 > - keda.authentication.triggerauthentication.created.v1 > - keda.authentication.triggerauthentication.updated.v1 > - keda.authentication.triggerauthentication.removed.v1 > - keda.authentication.clustertriggerauthentication.created.v1 > - keda.authentication.clustertriggerauthentication.updated.v1 > - keda.authentication.clustertriggerauthentication.removed.v1 ```
github-actions[bot] commented 3 weeks ago

Diff 2.16.0/manifests/keda.v2.16.0.clusterserviceversion.yaml \& 2.15.1/manifests/keda.v2.15.1.clusterserviceversion.yaml

```diff 29a30,51 > "apiVersion": "eventing.keda.sh/v1alpha1", > "kind": "ClusterCloudEventSource", > "metadata": { > "labels": { > "app.kubernetes.io/created-by": "keda", > "app.kubernetes.io/instance": "clustercloudeventsource-sample", > "app.kubernetes.io/managed-by": "kustomize", > "app.kubernetes.io/name": "clustercloudeventsource", > "app.kubernetes.io/part-of": "keda" > }, > "name": "clustercloudeventsource-sample" > }, > "spec": { > "clusterName": "clustercluster-sample", > "destination": { > "http": { > "uri": "http://foo.bar" > } > } > } > }, > { 140c162 < containerImage: ghcr.io/kedacore/keda-olm-operator:2.15.1 --- > containerImage: ghcr.io/kedacore/keda-olm-operator:2.16.0 148c170 < name: keda.v2.15.1 --- > name: keda.v2.16.0 156a179,181 > - kind: ClusterCloudEventSource > name: clustercloudeventsources.eventing.keda.sh > version: v1alpha1 626c651 < image: ghcr.io/kedacore/keda-olm-operator:2.15.1 --- > image: ghcr.io/kedacore/keda-olm-operator:2.16.0 699c724 < replaces: keda.v2.15.0 --- > replaces: keda.v2.15.1 701c726 < version: 2.15.1 --- > version: 2.16.0 ```
github-actions[bot] commented 3 weeks ago

Diff 2.16.0/manifests/keda.sh_scaledobjects.yaml \& 2.15.1/manifests/keda.sh_scaledobjects.yaml

```diff 6c6 < controller-gen.kubebuilder.io/version: v0.15.0 --- > controller-gen.kubebuilder.io/version: v0.16.5 9c9 < app.kubernetes.io/version: 2.15.1 --- > app.kubernetes.io/version: 2.16.0 35,40d34 < - jsonPath: .spec.triggers[*].type < name: Triggers < type: string < - jsonPath: .spec.triggers[*].authenticationRef.name < name: Authentication < type: string 52a47,52 > - jsonPath: .status.triggersTypes > name: Triggers > type: string > - jsonPath: .status.authenticationsTypes > name: Authentications > type: string 318a319,320 > authenticationsTypes: > type: string 395a398,399 > type: string > triggersTypes: ```
github-actions[bot] commented 3 weeks ago

Diff output of 2.16.0/manifests/keda.sh_scaledjobs.yaml is too large - character limit 65536 exceeded for github comment

github-actions[bot] commented 3 weeks ago

Diff 2.16.0/manifests/keda.sh_kedacontrollers.yaml \& 2.15.1/manifests/keda.sh_kedacontrollers.yaml

```diff 6c6 < controller-gen.kubebuilder.io/version: v0.15.0 --- > controller-gen.kubebuilder.io/version: v0.16.5 332c332 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 347c347 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 514c514 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 529c529 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 694c694 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 709c709 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 876c876 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 891c891 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 1049d1048 < 1053d1051 < 1063a1062,1067 > request: > description: |- > Request is the name chosen for a request in the referenced claim. > If empty, everything from the claim is made available, otherwise > only the result of this request. > type: string 1428c1432 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 1443c1447 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 1610c1614 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 1625c1629 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 1790c1794 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 1805c1809 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 1972c1976 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 1987c1991 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 2216d2219 < 2224d2226 < 2228d2229 < 2324d2324 < 2328d2327 < 2338a2338,2343 > request: > description: |- > Request is the name chosen for a request in the referenced claim. > If empty, everything from the claim is made available, otherwise > only the result of this request. > type: string 2703c2708 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 2718c2723 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 2885c2890 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 2900c2905 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 3065c3070 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 3080c3085 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 3247c3252 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 3262c3267 < This is an alpha field and requires enabling MatchLabelKeysInPodAffinity feature gate. --- > This is a beta field and requires enabling MatchLabelKeysInPodAffinity feature gate (enabled by default). 3429d3433 < 3433d3436 < 3442a3446,3451 > type: string > request: > description: |- > Request is the name chosen for a request in the referenced claim. > If empty, everything from the claim is made available, otherwise > only the result of this request. ```
github-actions[bot] commented 3 weeks ago

File 2.16.0/manifests/eventing.keda.sh_clustercloudeventsources.yaml wasn't found in previous version, its brand new!

github-actions[bot] commented 3 weeks ago

Diff 2.16.0/manifests/keda.sh_triggerauthentications.yaml \& 2.15.1/manifests/keda.sh_triggerauthentications.yaml

```diff 6c6 < controller-gen.kubebuilder.io/version: v0.15.0 --- > controller-gen.kubebuilder.io/version: v0.16.5 9c9 < app.kubernetes.io/version: 2.15.1 --- > app.kubernetes.io/version: 2.16.0 ```
github-actions[bot] commented 3 weeks ago

Diff 2.16.0/manifests/keda.sh_clustertriggerauthentications.yaml \& 2.15.1/manifests/keda.sh_clustertriggerauthentications.yaml

```diff 6c6 < controller-gen.kubebuilder.io/version: v0.15.0 --- > controller-gen.kubebuilder.io/version: v0.16.5 9c9 < app.kubernetes.io/version: 2.15.1 --- > app.kubernetes.io/version: 2.16.0 ```
jkyros commented 3 weeks ago

Looks great! Lots of cloudeventsource stuff this time. It's a shame about golangci-lint, but glad you got to the bottom of it :smile: /lgtm