Post Operator SDK 1.0 migration fixes - Githubissues

kedacore / keda-olm-operator

Operator for deploying KEDA Controller on OperatorHub.io/OLM

Apache License 2.0

31 stars 23 forks source link

Post Operator SDK 1.0 migration fixes #42

Closed zroubalik closed 3 years ago

zroubalik commented 4 years ago

LeaderElectionID: "olm.keda.sh" https://github.com/kedacore/keda-olm-operator/blob/e2d8ac262b9b69d5f1334438d7fb454d866fb9ab/main.go#L77
remove bin directory
in boilerplate.go.txt use content from kedacore/keda https://github.com/kedacore/keda-olm-operator/blob/master/hack/boilerplate.go.txt -> https://github.com/kedacore/keda/blob/v2/hack/boilerplate.go.txt
fix markers to comply with contents in rbac.yaml (and regenerate) https://github.com/kedacore/keda-olm-operator/blob/e2d8ac262b9b69d5f1334438d7fb454d866fb9ab/controllers/kedacontroller_controller.go#L75-L79
configmap and secret controllers are missing in controllers, original location: https://github.com/kedacore/keda-olm-operator/tree/a4d99c811486527aa917b1286d0cd130eb5cdf1d/pkg/controller

Makefile:

replace$IMG https://github.com/kedacore/keda-olm-operator/blob/e2d8ac262b9b69d5f1334438d7fb454d866fb9ab/Makefile#L66
- remove this: https://github.com/kedacore/keda-olm-operator/blob/e2d8ac262b9b69d5f1334438d7fb454d866fb9ab/Makefile#L17-L20
- replace $(CONTROLLER_GEN) $(CRD_OPTIONS) with $(CONTROLLER_GEN) crd:crdVersions=v1 https://github.com/kedacore/keda-olm-operator/blob/e2d8ac262b9b69d5f1334438d7fb454d866fb9ab/Makefile#L90