search

kedacore / keda

KEDA is a Kubernetes-based Event Driven Autoscaling component. It provides event driven scale for any container running in Kubernetes
https://keda.sh
Apache License 2.0
8.06k stars 1.01k forks source link

Provide Scaler for Oracle NoSQL Database #2289

Open nilayasiktoprak opened 2 years ago

nilayasiktoprak commented 2 years ago

Proposal

https://www.oracle.com/database/

Scaler Source

Oracle Database

Scaling Mechanics

Scale based on an Oracle SQL query outcome

Authentication Source

Password authentication will be used

Anything else?

No response

tomkerkhove commented 2 years ago

Great idea, are you willing to contribute it?

nilayasiktoprak commented 2 years ago

Yes :)

tomkerkhove commented 2 years ago

Awesome, thank you @nilayasiktoprak!

nilayasiktoprak commented 2 years ago

Hi, I'm using this library to develop the Oracle scaler: https://github.com/oracle/nosql-go-sdk and it supports 3 environments (Oracle Cloud, Oracle NoSQL Cloud Simulator, and On-Premise): https://github.com/oracle/nosql-go-sdk#configuring-the-sdk I have developed the scaler for on-premise and I would like to ask you if you think I should develop seperate scalers for these 3 environments or combine them all in one scaler? An example of a combined one here: https://github.com/oracle/nosql-go-sdk#simple-example Or maybe you can say that there is no need to develop a scaler for Cloud Simulator environment and I can just skip it. What are your suggestions?

JorTurFer commented 2 years ago

Thanks for the research! ❤️ IMO, having one scaler for all if they do the same for different envs it's the best option because it reduces the maintenance work. Any thoughts @kedacore/keda-core-contributors ? BTW, I thought that Oracle was a relational db, not NoSQL, do they use the same SDK?

nilayasiktoprak commented 2 years ago

There are Oracle NoSQL and Oracle (RDBMS). I decided to do the NoSQL one first so that's why I'm using that SDK. Alright, I'll put them all in one scaler. And for which environments do you think I should develop the scaler? All the three of them? Also maybe it would be better to change the name of the issue to Oracle NoSQL, right?

JorTurFer commented 2 years ago

TBH, I don't know enough about Orcale to know which environments could be better, but as far as I could see in the docs you sent, supporting more than 1 only changes the connection part, right? I mean, if support all of them is just adding more cases to the switch... But I can be missing something. At least (IMO), we should support on prem and cloud (but again, IDK about Oracle to know if both are used)

zroubalik commented 2 years ago

+1 to changing name to Oracle NoSQL

+1 to merging this to one scaler

Thanks for the work!

JorTurFer commented 5 months ago

Recently the CNCF has offered credit for Oracle Cloud. Could it be useful if we request it?