search

kedacore / keda

KEDA is a Kubernetes-based Event Driven Autoscaling component. It provides event driven scale for any container running in Kubernetes
https://keda.sh
Apache License 2.0
8.3k stars 1.05k forks source link

Provide e2e tests for Redis using Azure Cache for Redis #3325

Open tomkerkhove opened 2 years ago

tomkerkhove commented 2 years ago

Proposal

Provide e2e tests for Redis using Azure Cache for Redis by re-using the existing test suite against an Azure-based instance.

Use-Case

No response

Anything else?

This is as a follow-up to https://github.com/kedacore/keda/discussions/3306

JorTurFer commented 2 years ago

as I said in the discussion, I'm not sure if we need to cover it with e2e tests TBH, adding a simple test to cover the same scenario as already existing e2e tests without adding anything new IMO only add more code to maintain and more time to execute e2e tests

tomkerkhove commented 2 years ago

I don't want to burn @ahmelsayed's subscription but am trying to get a new one so let's see where this goes.

It can't hurt to keep tracking this in the backlog though.

JorTurFer commented 2 years ago

Agree, having the issue doesn't hurt xD Maybe you achieve a huge wallet for that subscription and makes sense having that Redis 😄

JorTurFer commented 1 year ago

Does this still make sense?