kedacore / keda

KEDA is a Kubernetes-based Event Driven Autoscaling component. It provides event driven scale for any container running in Kubernetes
https://keda.sh
Apache License 2.0
8.41k stars 1.06k forks source link

Broken link wiki/ScaledObject-spec and kubeval issue #557

Closed asears closed 4 years ago

asears commented 4 years ago

https://github.com/kedacore/keda/wiki/ScaledObject-spec - the link is broken.

Also kubeval is throwing errors with 404 not found for https://kubernetesjsonschema.dev/master-standalone/scaledobject-keda-v1alpha1.json.

Could someone update (or provide correct links to update and I will if I can get wiki access?)

Expected Behavior

No 404s

Actual Behavior

404s

Steps to Reproduce the Problem

  1. Hit the page
  2. 404s
tomkerkhove commented 4 years ago

Wiki is pending deletion: #460

Where did you find the link?

asears commented 4 years ago

I ran the kubeval utility on a keda configuration file. Perhaps this isn't the most recent api version, should be backwards compatible though.

apiVersion: keda.k8s.io/v1alpha1
kind: ScaledObject
metadata:
  name: my-scaler
  labels:
    app: my-app
    deploymentName: my-app
spec:
  scaleTargetRef:
    deploymentName: my-app
  minReplicaCount: 0 
  maxReplicaCount: 1
  triggers:
  - type: azure-servicebus
    metadata:
      queueName: myqueue
      connection: KEDA_SB_QUEUE_CONNECTIONSTRING
      queueLength: '1'
tomkerkhove commented 4 years ago

Isn't this more of a kubeval issue since it doesn't know our spec? Where did it get the link to the wiki?

I'm not really following where this error is coming from.

tomkerkhove commented 4 years ago

Looks like the tool that you are using depends on https://github.com/instrumenta/kubernetes-json-schema/tree/master/master-standalone which requires our spec to be there, is that what you are trying to say?

asears commented 4 years ago

Seems like there needs to be some updates to the definition in that repo, yes.

tomkerkhove commented 4 years ago

We don't actively maintain anything over there so you might want to open an issue there.

asears commented 4 years ago

Closing this issue

tomkerkhove commented 4 years ago

Sorry for not being able to help, but feel free to let us know if we can help with something else. If they can't help you we might be able to open an issue to contribute it.