Open ecerulm opened 6 months ago
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
WDYT @tomkerkhove @zroubalik ?
No objections, as long as Helm chart updates effectively update CRDs as well! I know there were some issues in that direction as part of https://github.com/kedacore/charts/issues/226
Are you willing to contribute this @ecerulm ?
yes, I can do this .
Duplicate of https://github.com/kedacore/charts/issues/226
Proposal
The CRDs can today be installed from the regular helm chart
kedacore/keda
but it's often good to have the the crds as an independent helm chart for example Karpenter provider karpenter and karpenter-crdUse-Case
The rationale for that is for upgrades see Karpenter CRD Upgrades
In karpenter , the
karpenter
helm chart only installs the CRDs on first installation, subsequent chart upgrades will not add or remove CRDs, even if the CRDs have changed.Having a separate helm chart for CRDs gives more control and allows me to deploy the CRDs from terraform (today this project provides the crds as a single file like https://github.com/kedacore/keda/releases/download/v2.13.1/keda-2.13.1-crds.yaml which is harder to deploy from a terraform perspective it's much easier if it's a helm release.
In any case it should be stated (here or in the documentation) what happens with the CRDs during an helm upgrade. It's my understanding by looking at the source code https://github.com/kedacore/charts/blob/main/keda/templates/crds/crd-triggerauthentications.yaml that today keda helm chart will always overwrite.
Is this a feature you are interested in implementing yourself?
Maybe
Anything else?
No response