Refactor Scalers with new declarative scaler config

dttung2905 commented 6 months ago

Proposal

We can take turn implement the changes in this PR https://github.com/kedacore/keda/pull/5676. This is related to the original issue here https://github.com/kedacore/keda/issues/5037. I can take the kafka one since I have been working on something similar in https://github.com/kedacore/keda/pull/5319

[x] activemq_scaler.go https://github.com/kedacore/keda/pull/5799
[x] apache_kafka_scaler.go https://github.com/kedacore/keda/pull/5804
[x] arangodb_scaler.go https://github.com/kedacore/keda/pull/5808
[x] artemis_scaler.go https://github.com/kedacore/keda/pull/5836
[x] aws_cloudwatch_scaler.go https://github.com/kedacore/keda/pull/5852
[x] aws_dynamodb_scaler.go https://github.com/kedacore/keda/pull/5961
[ ] aws_dynamodb_streams_scaler.go
[ ] aws_kinesis_stream_scaler.go
[ ] aws_sqs_queue_scaler.go
[ ] azure_app_insights_scaler.go
[ ] azure_blob_scaler.go
[ ] azure_data_explorer_scaler.go
[ ] azure_eventhub_scaler.go
[ ] azure_log_analytics_scaler.go
[ ] azure_monitor_scaler.go
[ ] azure_pipelines_scaler.go
[ ] azure_queue_scaler.go
[ ] azure_servicebus_scaler.go
[ ] cassandra_scaler.go
[ ] couchdb_scaler.go
[ ] cpu_memory_scaler.go
[ ] cron_scaler.go
[ ] datadog_scaler.go
[ ] elasticsearch_scaler.go
[ ] etcd_scaler.go
[ ] external_mock_scaler.go
[ ] external_scaler.go
[ ] gcp_cloud_tasks_scaler.go
[ ] gcp_pubsub_scaler.go
[ ] gcp_stackdriver_scaler.go
[ ] gcp_storage_scaler.go
[ ] github_runner_scaler.go
[ ] graphite_scaler.go
[ ] huawei_cloudeye_scaler.go
[x] ibmmq_scaler.go https://github.com/kedacore/keda/pull/6034
[ ] influxdb_scaler.go
[ ] kafka_scaler.go
[ ] kubernetes_workload_scaler.go
[ ] liiklus_scaler.go
[ ] loki_scaler.go
[ ] metrics_api_scaler.go
[ ] mongo_scaler.go
[ ] mssql_scaler.go
[ ] mysql_scaler.go
[ ] nats_jetstream_scaler.go
[ ] newrelic_scaler.go
[ ] openstack_metrics_scaler.go
[ ] openstack_swift_scaler.go
[ ] postgresql_scaler.go
[x] predictkube_scaler.go https://github.com/kedacore/keda/pull/6282
[ ] prometheus_scaler.go
[ ] pulsar_scaler.go
[ ] rabbitmq_scaler.go
[ ] redis_scaler.go
[ ] redis_streams_scaler.go
[ ] selenium_grid_scaler.go
[ ] solace_scaler.go
[x] solr_scaler.go https://github.com/kedacore/keda/pull/5818
[ ] stan_scaler.go

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response

SpiritZhou commented 6 months ago

I can help to do some of them.

dttung2905 commented 6 months ago

Sure. Me and @wozniakjan is doing from top down. May be you want to try doing from bottom up?

wozniakjan commented 6 months ago

fyi @SpiritZhou, @dttung2905 no need to introduce changelog entry for each PR, it will be mentioned in one place - https://github.com/kedacore/keda/pull/5799#discussion_r1604839131

stale[bot] commented 3 months ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

wozniakjan commented 3 months ago

@stale unstale please? :)

kedacore / keda