Allow CA dirs to be specified beyond /custom/ca/

kedacore / keda

KEDA is a Kubernetes-based Event Driven Autoscaling component. It provides event driven scale for any container running in Kubernetes

https://keda.sh

Apache License 2.0

8.01k stars 1.01k forks source link

Allow CA dirs to be specified beyond /custom/ca/ #5859

Closed joelsmith closed 1 week ago

joelsmith commented 3 weeks ago

Add --ca-dir flag to KEDA operator to specify directories with CA certificates for scalers to authenticate TLS connections (defaults to /custom/ca)

Checklist

[X] I have verified that my change is according to the deprecations & breaking changes policy
[X] Tests have been added
[X] Changelog has been updated and is aligned with our changelog requirements
[X] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[X] A PR is opened to update the documentation on (repo) (if applicable)
[X] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5860

See https://github.com/kedacore/charts/pull/650 See https://github.com/kedacore/keda-docs/pull/1402

zroubalik commented 3 weeks ago

@joelsmith could you please create an issue to track this feature and link it in the changelog & docs/helm PRs then? Thanks

joelsmith commented 3 weeks ago

Hi @zroubalik, I have created the issue and the docs & chart PRs. I think they are ready for a review. Thanks!

zroubalik commented 3 weeks ago

/run-e2e internal Update: You can check the progress here

joelsmith commented 3 weeks ago

BTW, because of the added loop and resulting indent increase, the patch is easier to read with ?w=1 added to the URL, like this: https://github.com/kedacore/keda/pull/5859/files?w=1 I'm not sure why the e2e failed... the error shows that the KEDA operator did not become ready fast enough, but looking at the operator's log, it did become ready. So maybe it was just too slow.

zroubalik commented 3 weeks ago

/run-e2e internal Update: You can check the progress here

joelsmith commented 3 weeks ago

@zroubalik Thanks for re-running the test -- it passed this time. Thanks!

JorTurFer commented 1 week ago

/run-e2e internal Update: You can check the progress here