Add eagerScalingStrategy for ScaledJob

kedacore / keda

KEDA is a Kubernetes-based Event Driven Autoscaling component. It provides event driven scale for any container running in Kubernetes

https://keda.sh

Apache License 2.0

8.01k stars 1.01k forks source link

Add eagerScalingStrategy for ScaledJob #5872

Open junekhan opened 3 weeks ago

junekhan commented 3 weeks ago

Added eagerScalingStrategy for ScaledJob

Checklist

[x] When introducing a new scaler, I agree with the scaling governance policy
[x] I have verified that my change is according to the deprecations & breaking changes policy
[x] Tests have been added
[x] Changelog has been updated and is aligned with our changelog requirements
[x] A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
[x] A PR is opened to update the documentation on (repo) (if applicable)
[x] Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5114

Relates to #

junekhan commented 1 week ago

Could you please open pr in https://github.com/kedacore/keda-docs/ to cover this new feature?

Sure, thanks! Will do that.

zroubalik commented 5 days ago

/run-e2e internal Update: You can check the progress here

junekhan commented 5 days ago

@zroubalik Hi there, I'm sorry that the e2e test didn't go well. I'm glad to analyze the logs, although it seems that I don't have access to it.

zroubalik commented 3 days ago

@junekhan you should be able to access the logs by following these steps (let me know if you are not):

junekhan commented 2 days ago

@zroubalik Thanks for your input. I have no problem accessing the test suite log you mentioned, but I was looking for the log from inside the cluster, which can contain information about how the scaling decision was made. The test suite log only shows that the scaling didn't happen a single time, otherwise, I didn't find any clues.

zroubalik commented 2 days ago

@zroubalik Thanks for your input. I have no problem accessing the test suite log you mentioned, but I was looking for the log from inside the cluster, which can contain information about how the scaling decision was made. The test suite log only shows that the scaling didn't happen a single time, otherwise, I didn't find any clues.

At the bottom of the output, there's log from KEDA operator as well. That's the best we can do, you can always run the failed test locally: https://github.com/kedacore/keda/tree/main/tests#specific-test

junekhan commented 2 days ago

@zroubalik Thanks for your input. I have no problem accessing the test suite log you mentioned, but I was looking for the log from inside the cluster, which can contain information about how the scaling decision was made. The test suite log only shows that the scaling didn't happen a single time, otherwise, I didn't find any clues.

At the bottom of the output, there's log from KEDA operator as well. That's the best we can do, you can always run the failed test locally: https://github.com/kedacore/keda/tree/main/tests#specific-test

@zroubalik Thanks for your hint! That looks daunting 😨 but I will try.

junekhan commented 1 day ago

Could you please rerun the checks? The result doesn't make sense.