search

kedder / ofxstatement

Tool to convert proprietary bank statement to OFX format, suitable for importing to GnuCash or other personal finance applications.
GNU General Public License v3.0
287 stars 61 forks source link

Support for investment transactions #128

Closed darkms closed 3 years ago

darkms commented 3 years ago

Hi, thanks for this awesome project!

Just wanted to let you know that I've implemented support for investment transactions rendered to OFX in my fork (exporter plugin). The output OFX works more or less OK with KMyMoney.

Would you be interested in having such a feature supported in this repo? (I'll raise a PR if yes)

kedder commented 3 years ago

Hi @darkms! I think this feature makes sense, fits in the scope of ofxstatement and I welcome the pull request :)

One thing I suggest is to create another sample ofx file to test investment transactions instead of modifying the existing one (and writing a separate test for investment transactions). I find it easier to debug isolated tests when things break.

darkms commented 3 years ago

Thx @kedder, made a few changes as you've advised and raised a PR #129