search

kedder / ofxstatement

Tool to convert proprietary bank statement to OFX format, suitable for importing to GnuCash or other personal finance applications.
GNU General Public License v3.0
277 stars 61 forks source link

Fix STMTTRN child order #243

Closed dvdkon closed 11 months ago

dvdkon commented 11 months ago

Some parsers (notably libofx) use a DTD for parsing OFX files. This means that child element order is fixed, and the wrong order won't verify or parse. I've reordered <STMTTRN>'s children so that the order matches the above DTD and the OFX spec.

kedder commented 11 months ago

Interesting! It makes sense, could you please fix tests as well?

dvdkon commented 11 months ago

Oops, didn't think to check for tests. It should be all good now.

coveralls commented 11 months ago

Coverage Status

coverage: 95.498%. remained the same when pulling b3229b0f0d8fd5e255ce04e2e04d507ca18caa6b on dvdkon:master into 8c838fb85e3b31b385cca7675669cd6586d82d28 on kedder:master.

kedder commented 11 months ago

Merged! Do you want a new release with this?

dvdkon commented 11 months ago

Thanks. I'll be fine using my local copy, but maybe someone else would appreciate a release.