Fix STOCKINFO tag generation for investment files

kedder / ofxstatement

Tool to convert proprietary bank statement to OFX format, suitable for importing to GnuCash or other personal finance applications.

GNU General Public License v3.0

270 stars 61 forks source link

Fix STOCKINFO tag generation for investment files #255

Closed jaik03 closed 6 months ago

jaik03 commented 6 months ago

OFX STOCKINFO tags need to be closed and repeated for each individual security. Leaving the tag off leads to unexpected behavior in GNUCash (and potentially other software).

kedder commented 6 months ago

Yeah, according to [this] you seem to be right.

Meanwhile, it looks like ofxstatement build got completely broken. I'll fix it in a separate PR.

jaik03 commented 6 months ago

Thanks. I'm developing a plugin to import JSON brokerage exports from Schwab, and this was giving me fits testing the import into GNUCash. I'll have another couple minor PRs as I go.

kedder commented 6 months ago

Could you please rebase this branch on master (to fix the build)?

jaik03 commented 6 months ago

Could you please rebase this branch on master (to fix the build)?

Done!

coveralls commented 6 months ago

coverage: 95.724%. remained the same when pulling 6fa37fedf788620da6017786031f1999f6eead11 on jaik03:Move-STOCKINFO into 4c4a51794944f24e9ace04cd663fea3a28731481 on kedder:master.