Handle additional types of investment transactions

kedder / ofxstatement

Tool to convert proprietary bank statement to OFX format, suitable for importing to GnuCash or other personal finance applications.

GNU General Public License v3.0

270 stars 61 forks source link

Handle additional types of investment transactions #273

Closed edwagner closed 4 months ago

edwagner commented 4 months ago

I'm in the process of building a plugin to convert Charles Schwab JSON exports to OFX, and need to write out some additional types of investment transactions in a way that is consumable by Gnucash.

Hopefully most if this is additive (i.e. shouldn't negatively impact current behavior) with the exception of limiting the precision of the total to 2 decimal places. IIRC, more than two decimal places on the total caused a problem importing into Gnucash.

edwagner commented 4 months ago

It looks like it was a mypy error. I'm pretty new to Python and I hadn't looked at the various checks your actions run. I've pushed an update that should pass both mypy and black.

coveralls commented 4 months ago

coverage: 96.033% (+0.5%) from 95.514% when pulling 8c1112c2a31bad3726360618b02e8f9160d4cc65 on edwagner:invest-statement-enhancements into cfd9002d437edc48f432fad245f72b021a2580ad on kedder:master.