search

kedgeproject / kedge

Kedge : Simple, Concise & Declarative Kubernetes Applications
Apache License 2.0
298 stars 41 forks source link

make e2e tests not run in verbose mode #379

Open surajssd opened 7 years ago

surajssd commented 7 years ago

Based on the discussion here, we should move from verbose mode of running e2e tests to running tests in normal mode. We don't necessarily need verbose because golang test suite will dump the output of the failed test anyway if any test fails.

kadel commented 7 years ago

big +1 it is impossible to find anything useful in current output. verbose output should be dumped only if there is an error

cdrage commented 6 years ago

PR updated here: https://github.com/kedgeproject/kedge/pull/388

kadel commented 6 years ago

semaphore e2e tests are still verbose. It is really hard to find out why the test is failing in all that input.

I really like go test behavior, if everything is ok, it just prints OK and nothing more. If the test fails that verbose output is shown, but only for failed tests. We should do the same for our e2e tests

ashetty1 commented 6 years ago

@kadel I think the verbose mode in CI is intentional. Could be changed if you'd like.

kadel commented 6 years ago

We should also clean up errors, that are actually not errors, like showing

0: dial tcp 192.168.122.112:31850: getsockopt: connection refused
        e2e_test.go:217: error while making http request "http://192.168.122.112:31850" for service "web:80", err: Get http://192.168.122.112:31850: dial tcp 192.168.122.112:31850: getsockopt: connection refused

while waiting for pods to come up. Technically this is not error. An error means that something went wrong that is permanent and it can't be recovered from. This is error only when it times up.