kedgeproject / kedge

Kedge : Simple, Concise & Declarative Kubernetes Applications
Apache License 2.0
298 stars 41 forks source link

Follow Label and Annotation Recommendations #585

Open kadel opened 6 years ago

kadel commented 6 years ago

https://docs.google.com/document/d/1EVy0wRJRm5nogkHl38fNKbFrhERmSL_CLNE4cxcsc_M/edit#

It would be nice if kedge uses recommendations from that document, at least for name and version (app.kubernetes.io/name, app.kubernetes.io/version)

Right now we use app and appversion, I propose chenging appversion to app.kubernetes.io/version , keeping app as it is and adding app.kubernetes.io/name that will have same value as app. (We are keeping app labels because OpenShift uses it to group objects in web console)

kadel commented 6 years ago

we could also add app.kubernetes.io/deploy-manager: kedge as a label

cdrage commented 6 years ago

This is as simple as adding to Kedge application labels on generation / creation, correct?

For example:

metadata:
  annotations:
    appversion: 0.8.1
  creationTimestamp: null
  labels:
    app: httpd
    app.kubernetes.io/name: httpd
    app.kubernetes.io/version: 0.0.1
  name: httpd
surajnarwade commented 6 years ago

@cdrage @kadel , what's the status on community acceptance of labels/annotations proposal ?

surajnarwade commented 6 years ago

Some queries:

for wordpress.yml :

metadata:
  creationTimestamp: null
  labels:
    app: wordpress
    app.kubernetes.io/name: wordpress
  name: wordpress

For mariadb :

metadata:
  creationTimestamp: null
  labels:
    app: database
    app.kubernetes.io/name: database
  name: database