Open kadel opened 6 years ago
we could also add app.kubernetes.io/deploy-manager: kedge
as a label
This is as simple as adding to Kedge application labels on generation / creation, correct?
For example:
metadata:
annotations:
appversion: 0.8.1
creationTimestamp: null
labels:
app: httpd
app.kubernetes.io/name: httpd
app.kubernetes.io/version: 0.0.1
name: httpd
@cdrage @kadel , what's the status on community acceptance of labels/annotations proposal ?
Some queries:
Consider wordpress
examples
if I added these labels, it will be something like:
for wordpress.yml
:
metadata:
creationTimestamp: null
labels:
app: wordpress
app.kubernetes.io/name: wordpress
name: wordpress
For mariadb
:
metadata:
creationTimestamp: null
labels:
app: database
app.kubernetes.io/name: database
name: database
It indicates, wordpress
& mariadb
both are different applications but it should be like, mariadb
is component of wordpress
.
@cdrage @kadel @containscafeine thoughts? (I might be completely wrong here)
https://docs.google.com/document/d/1EVy0wRJRm5nogkHl38fNKbFrhERmSL_CLNE4cxcsc_M/edit#
It would be nice if kedge uses recommendations from that document, at least for name and version (
app.kubernetes.io/name
,app.kubernetes.io/version
)Right now we use
app
andappversion
, I propose chengingappversion
toapp.kubernetes.io/version
, keepingapp
as it is and addingapp.kubernetes.io/name
that will have same value asapp
. (We are keepingapp
labels because OpenShift uses it to group objects in web console)