search

kedro-org / kedro-brand-identity

Brand identity for the Kedro project
https://kedro.org/
Other
4 stars 1 forks source link

Are the SVG icons optimized? #4

Open stichbury opened 1 year ago

stichbury commented 1 year ago

Hi there!

I'm creating a set of icons in the simple-icons repo https://github.com/simple-icons/simple-icons since that will give us a set of badges for people to include on their repos/projects. Currently, we just have a hacky version that @astrojuanlu created as a temporary measure:

Screenshot 2023-09-04 at 16 01 37

I have to answer some questions as part of the PR that submits the icons:

Please can @stephkaiser @Mackay031 or @amandakys confirm whether the icon is optimized and the viewbox for the SVG, since I have no idea if this is correct? (I'm interested in the 3 colors of icon in the /icon folder). If there isn't an answer to these, would it be possible to add a task to check and optimize/set the viewbox please? Or let me know the appropriate tool and I'll attempt it.

Thank you 🙏

stephkaiser commented 1 year ago

hey @stichbury, happy to help with this. Where can I find the svg created by Juan Lu? the one attached above is a png image. Also could you show where I can find the colours in the icon folder? thanks :)

stichbury commented 1 year ago

Hi @stephkaiser

We don't need to reproduce what @astrojuanlu has made -- the simple-icons service is basically doing that part of the work for us. Their service is so you can make a URL and specify Kedro (or another brand) and when you specify it, it's rendered aas the lozenge for you. For example, we already use some of these in Kedro docs where we write something like this https://img.shields.io/badge/license-Apache%202.0-blue.svg and it auto-renders to this:

licence

Juan Lu did much the same to create what I included above, but because they don't currently have the Kedro logo, he used a black diamond symbol as follows: https://img.shields.io/badge/powered_by-%E2%AC%A5_kedro-ffc900

renders to: this

So all we need to do is to supply the three icon svg in this repo to simple-icons who will then host and offer the service to build custom URLs to display them. I can do that, but just need confirmation that the icons in the repo are optimized and what their viewbox is. Hope that sounds OK?

stephkaiser commented 1 year ago

Thank you @stichbury for the explanation, it's much clearer to me now 👍

I would assume the three icon svgs are not optimised, thats usually the case when they are exported from design software like Figma, Sketch or Illustrator. The current icons also have a viewbox of 0 0 200 200.

I've now optimised the three Kedro icon svgs and they all have the correct viewbox 0 0 24 24 🙌 I've uploaded the optimised svg icons in our Kedro Box folder, and also created a pull request in the kedro-brand-identity repo here (apologies if I've not done the PR correctly :D) - https://github.com/kedro-org/kedro-brand-identity/pull/5

Could you please review and approve?

Additional Q @stichbury - do you also need optimised svgs for the other logo formats? eg. the full kedro logo with icon + text?

stichbury commented 1 year ago

Hi @stephkaiser that all looks great to me, thanks. I've approved and merged your PR. I don't think we need the optimisation for the other logos right now, certainly not for this task, so let's leave until we're asked for them. All sorted and really swiftly -- thank you so much 🙏