Closed stichbury closed 3 months ago
I'd point to @deepyaman 's example in the Ibis as a representative of real world usage https://github.com/deepyaman/jaffle-shop/blob/main/.github/workflows/kedro-viz.yml
And this as a example of how we need to fix the consent workflow in non-interactive environments 😂 https://github.com/deepyaman/jaffle-shop/blob/48d47db7bfae4495f84cfafb1217923a7cf7b49b/.github/workflows/kedro-viz.yml#L26C8-L26C49
https://github.com/kedro-org/kedro/issues/2867 cc @astrojuanlu
And this as a example of how we need to fix the consent workflow in non-interactive environments 😂 https://github.com/deepyaman/jaffle-shop/blob/48d47db7bfae4495f84cfafb1217923a7cf7b49b/.github/workflows/kedro-viz.yml#L26C8-L26C49
kedro-org/kedro#2867 cc @astrojuanlu
Yeah, I referenced https://github.com/kedro-org/kedro/issues/1640#issuecomment-1162843460 in deciding how to handle it, and turned it on because @yetudada had commented that we want telemetry for CI (of course, it's not distinguishable right now).
Putting this on hold subject to fixes needed. @NeroOkwa to advise when he has a draft.
Bug fixes have been implemented, and blog post draft has been written. The only outstanding is the Github Actions implementation next sprint.
Moving this back to "In Review" with your permission
The definition of Done would be "the blog post has been published on https://kedro.org/blog"
Weird: the post contains 3 repeated images (see "Published Kedro Viz" and "Published Kedro Viz (alt)")
despite Contentful seemingly being all right
https://app.contentful.com/spaces/zwej9aiux6b9/entries/3oO0axFx7Pn1BBg9aXP9Jb?focusedField=title
And even the Medium import correctly separated the 3 images https://medium.com/@kedro/share-a-kedro-viz-with-github-pages-ef0d3892244b
Any clue @rashidakanchwala ?
Not sure what happened but the problem is gone!
We think a follow-up page to the initial announcement about sharing a Viz would be good https://kedro.org/blog/how-to-share-a-kedro-viz-pipeline-visualisation now that there are other options for hosting beyond S3.