search

kedro-org / kedro-plugins

First-party plugins maintained by the Kedro team.
Apache License 2.0
94 stars 90 forks source link

Possibly invalid pandas extras metadata in `kedro-datasets` #863

Closed mariusz89016 closed 1 month ago

mariusz89016 commented 1 month ago

Hello 👋

During requirements compilation (pip-compile requirements.in) I get a warning:

WARNING: kedro-datasets 4.1.0 does not provide the extra 'pandas-gbqtabledataset-pandas-genericdataset'

It works but in compiled requirements.txt there's:

#   scroll to the right =>                                                                                                                       \/\/\/\/\/\/\/\/\/\/\/\/\/\/\/\/
kedro-datasets[pandas,pandas-base,pandas-csvdataset,pandas-deltatabledataset,pandas-exceldataset,pandas-featherdataset,pandas-gbqquerydataset,pandas-gbqtabledataset-pandas-genericdataset,pandas-hdfdataset,pandas-jsondataset,pandas-parquetdataset,pandas-sqlquerydataset,pandas-sqltabledataset,pandas-xmldataset]==4.1.0

In requirements.in I have an entry:

kedro-datasets[pandas]==4.1.0

...aaaand I think that root cause of this is dot instead of comma here: https://github.com/kedro-org/kedro-plugins/blob/kedro-datasets-4.1.0/kedro-datasets/pyproject.toml#L107

Thanks in advance ☺️

noklam commented 1 month ago

@mariusz89016 Thanks for opening your first issue in Kedro! You are absolutely right and this should be an easy fix, do you want to open a PR?

mariusz89016 commented 1 month ago

Yeah, definitely ☺️ I'll prepare a PR in a moment!