Fix Subproject is no longer highlighted

kedro-org / kedro-sphinx-theme

Apache License 2.0

2 stars 0 forks source link

Fix Subproject is no longer highlighted #9

Closed Huongg closed 3 weeks ago

Huongg commented 3 weeks ago

Fixes #4 , to ensure the tab-menu (or subproject) is highlighted.

The fixes include:

Assign a unique ID to each subproject tab
When the page is loading, check the current path from window.location, and map through the existing unique ID, if matches, it should highlight that menu tab

📚 Documentation preview 📚: https://kedro-sphinx-theme--9.org.readthedocs.build/en/9/

astrojuanlu commented 3 weeks ago

Yeah this package famously has no tests 😬 That's why the CI is broken...

This repo doesn't have branch protections in it so I will go ahead and merge, but I'm opening a separate ticket to do something about the CI before we tag the next release.