Replace use of deprecated `_package_name` variable - Githubissues

kedro-org / kedro-starters

Templates for your Kedro projects.

Apache License 2.0

63 stars 57 forks source link

Replace use of deprecated `_package_name` variable #125

Closed deepyaman closed 1 year ago

deepyaman commented 1 year ago

Motivation and Context

Closes kedro-org/kedro-starters#123

How has this been tested?

Spun up a Codespace using https://github.com/jplane/pyspark-devcontainer
Verified installed Spark version is 3.4
Created a new project with starter pyspark-iris
Installed the requirements for the starter
Ran into the raised issue
Replaced hook with the suggested fix
Reran, and it works

Checklist

[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Assigned myself to the PR
[ ] Added tests to cover my changes

astrojuanlu commented 1 year ago

I see these were introduced in https://github.com/kedro-org/kedro-starters/pull/102/

astrojuanlu commented 1 year ago

Also, where does it say that _package_name is deprecated? I couldn't find it anywhere...

deepyaman commented 1 year ago

Also, where does it say that _package_name is deprecated? I couldn't find it anywhere...

It's not super clear, but maybe something like https://github.com/kedro-org/kedro/pull/1953/files or the linked issue? @merelcht may know better on this one.