search

kedro-org / kedro-starters

Templates for your Kedro projects.
Apache License 2.0
64 stars 59 forks source link

CI is broken #137

Closed astrojuanlu closed 1 year ago

astrojuanlu commented 1 year ago

https://github.com/kedro-org/kedro-starters/pull/136 made a one character change in the README but there were some test failures.

https://app.circleci.com/pipelines/github/kedro-org/kedro-starters/618/workflows/687e92b1-d6d7-41e1-9348-dc8566bb9c39/jobs/6650

Failing scenarios:
  features/run.feature:26  Run a Kedro project created from pyspark-iris

0 features passed, 1 failed, 0 skipped
4 scenarios passed, 1 failed, 0 skipped
24 steps passed, 1 failed, 0 skipped, 0 undefined
Took 3m56.385s

Exited with code exit status 1

CircleCI received exit code 1

This is the error:

DatasetError: An exception occurred when parsing config for dataset 
'example_classifier':
Dataset type 'kedro.io.memory_dataset.MemoryDataSet' is invalid: all data set 
types must extend 'AbstractDataSet'.
astrojuanlu commented 1 year ago

Root cause:

https://github.com/kedro-org/kedro-starters/blob/2d86c0f2bbf5e535a7c0ec3f2470e979990df966/pyspark-iris/%7B%7B%20cookiecutter.repo_name%20%7D%7D/conf/base/catalog.yml#L97-L103

and

https://github.com/kedro-org/kedro/blob/fd8162d5bf384ef666c01ef2c529d01fd9fa8354/kedro/io/core.py#L427-L431

astrojuanlu commented 1 year ago

In progress at https://github.com/kedro-org/kedro/pull/2724

astrojuanlu commented 1 year ago

Test: gh-138