search

kedro-org / kedro-starters

Templates for your Kedro projects.
Apache License 2.0
63 stars 57 forks source link

Make starters use `OmegaConfigLoader` #143

Closed astrojuanlu closed 10 months ago

astrojuanlu commented 11 months ago

Description

Right now, the starters show a FutureWarning because they use the ConfigLoader, which is deprecated.

[08/17/23 11:53:39] INFO     Kedro project test-graph                                        session.py:364
                    WARNING  /Users/juan_cano/.micromamba/envs/kedro310/lib/python3.10/site warnings.py:109
                             -packages/kedro/framework/session/session.py:266:                             
                             FutureWarning: ConfigLoader will be deprecated in Kedro 0.19.                 
                             Please use the OmegaConfigLoader instead. To consult the                      
                             documentation for OmegaConfigLoader, see here:                                
                             https://docs.kedro.org/en/stable/configuration/advanced_config                
                             uration.html#omegaconfigloader                                                
                               warnings.warn(
ankatiyar commented 10 months ago

@astrojuanlu Should this also be changed for the template used for kedro new?

astrojuanlu commented 10 months ago

Relying some offline discussion: yes, this should be done on kedro new as well and can be done in 0.18.x, because kedro run and all commands should work the same for new and old templates (hence this wouldn't be a breaking change).

noklam commented 10 months ago

Linked #145 to this issue. We should also update kedro because the template lives in kedro codebase. @lrcouto

lrcouto commented 10 months ago

Update on the kedro repository is on this PR: https://github.com/kedro-org/kedro/pull/2974