kedro-org / kedro-starters

Templates for your Kedro projects.

Apache License 2.0

64 stars 59 forks source link

Change starters to use OmegaConfigLoader #145

Closed lrcouto closed 1 year ago

lrcouto commented 1 year ago

Motivation and Context

Part of the resolution for Make starters use OmegaConfigLoader. Changes on the kedro repo can be seen on this PR.

How has this been tested?

Tested on gitpod workspace running make test, and by creating a new Kedro project with a starter.

Checklist

[x] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[x] Assigned myself to the PR
[x] Added tests to cover my changes

noklam commented 1 year ago

Linting is failing - you may want to try to do a kedro new and run kedro lint to see what's wrong.

You can do kedro new --checkout <branch> to use starters that are in feature branch.

noklam commented 1 year ago

/tmp/tmp53i8letx/project-dummy/src/project_dummy/settings.py:25:1: E402 module level import not at top of file

If you read the log or try to run it locally you will see this error. I think we need to suppress the linting, and in 0.19 the default should be just OmegaConfigLoader.

lrcouto commented 1 year ago

/tmp/tmp53i8letx/project-dummy/src/project_dummy/settings.py:25:1: E402 module level import not at top of file

If you read the log or try to run it locally you will see this error. I think we need to suppress the linting, and in 0.19 the default should be just OmegaConfigLoader.

Yeah I see it now. Do you suppress it with #fmt: on/off for Black or is there something else that needs to be done?

noklam commented 1 year ago

@lrcouto https://www.flake8rules.com/rules/E402.html - the warning should be coming from flake, which is usually with inline comment # noqa: E402. You can search for noqa in the code base to find similar example.

lrcouto commented 1 year ago

@lrcouto https://www.flake8rules.com/rules/E402.html - the warning should be coming from flake, which is usually with inline comment # noqa: E402. You can search for noqa in the code base to find similar example.

Thank you!

astrojuanlu commented 1 year ago

Tests failing because of PyYAML and Cython 3 https://github.com/yaml/pyyaml/issues/601#issuecomment-1661960662

144 updated the PyYAML upper version cap, so hopefully updating this branch should suffice.