Drop python 3.7 from starters

kedro-org / kedro-starters

Templates for your Kedro projects.

Apache License 2.0

64 stars 59 forks source link

Drop python 3.7 from starters #159

Closed SajidAlamQB closed 11 months ago

SajidAlamQB commented 11 months ago

Motivation and Context

Dropping python 3.7 support for starters.

How has this been tested?

Changed test_requirements.txt to use develop over main since we are moving to 0.19.0 and it will help unblock develop to use starters with the new add-ons flow.

Checklist

[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[x] Assigned myself to the PR
[ ] Added tests to cover my changes

merelcht commented 11 months ago

Great stuff @SajidAlamQB ! We'll need to wait with merging this until 0.18.14 is out though.

SajidAlamQB commented 11 months ago

It looks like the renamed _data_sets attribute in Catalog to _datasets is causing issues with kedro-viz. kedro_viz/integrations/kedro/hooks.py on L34 is referencing self.datasets = catalog._data_sets which will need to be updated once 0.19 is out but in the meantime, since this PR aims to switch to develop branch, it will conflict with viz.

merelcht commented 11 months ago

It looks like the renamed _data_sets attribute in Catalog to _datasets is causing issues with kedro-viz. kedro_viz/integrations/kedro/hooks.py on L34 is referencing self.datasets = catalog._data_sets which will need to be updated once 0.19 is out but in the meantime, since this PR aims to switch to develop branch, it will conflict with viz.

I've opened this PR https://github.com/kedro-org/kedro-viz/pull/1587 to fix that 🙂

SajidAlamQB commented 11 months ago

LGTM! Do we need a reminder ticket to set the kedro-viz and kedro requirements back to what they were?

Created an issue to remind us, https://github.com/kedro-org/kedro-starters/issues/161. Once kedro 0.19.0 and next update of kedro-viz are out we can revert the changes made to the requirements.